New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deferrable mode to DbtCloudRunJobOperator
#29014
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,119 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
from __future__ import annotations | ||
|
||
import asyncio | ||
import time | ||
from typing import Any, AsyncIterator | ||
|
||
from airflow.providers.dbt.cloud.hooks.dbt import DbtCloudHook, DbtCloudJobRunStatus | ||
from airflow.triggers.base import BaseTrigger, TriggerEvent | ||
|
||
|
||
class DbtCloudRunJobTrigger(BaseTrigger): | ||
""" | ||
DbtCloudRunJobTrigger is triggered with run id and account id, makes async Http call to dbt and | ||
get the status for the submitted job with run id in polling interval of time. | ||
|
||
:param conn_id: The connection identifier for connecting to Dbt. | ||
:param run_id: The ID of a dbt Cloud job. | ||
:param end_time: Time in seconds to wait for a job run to reach a terminal status. Defaults to 7 days. | ||
:param account_id: The ID of a dbt Cloud account. | ||
:param poll_interval: polling period in seconds to check for the status. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
conn_id: str, | ||
run_id: int, | ||
end_time: float, | ||
poll_interval: float, | ||
account_id: int | None, | ||
): | ||
super().__init__() | ||
self.run_id = run_id | ||
self.account_id = account_id | ||
self.conn_id = conn_id | ||
self.end_time = end_time | ||
self.poll_interval = poll_interval | ||
|
||
def serialize(self) -> tuple[str, dict[str, Any]]: | ||
"""Serializes DbtCloudRunJobTrigger arguments and classpath.""" | ||
return ( | ||
"airflow.providers.dbt.cloud.triggers.dbt.DbtCloudRunJobTrigger", | ||
{ | ||
"run_id": self.run_id, | ||
"account_id": self.account_id, | ||
"conn_id": self.conn_id, | ||
"end_time": self.end_time, | ||
"poll_interval": self.poll_interval, | ||
}, | ||
) | ||
|
||
async def run(self) -> AsyncIterator["TriggerEvent"]: | ||
"""Make async connection to Dbt, polls for the pipeline run status""" | ||
hook = DbtCloudHook(self.conn_id) | ||
try: | ||
while await self.is_still_running(hook): | ||
if self.end_time < time.time(): | ||
yield TriggerEvent( | ||
{ | ||
"status": "error", | ||
"message": f"Job run {self.run_id} has not reached a terminal status after " | ||
f"{self.end_time} seconds.", | ||
"run_id": self.run_id, | ||
} | ||
) | ||
await asyncio.sleep(self.poll_interval) | ||
job_run_status = await hook.get_job_status(self.run_id, self.account_id) | ||
if job_run_status == DbtCloudJobRunStatus.SUCCESS.value: | ||
yield TriggerEvent( | ||
{ | ||
"status": "success", | ||
"message": f"Job run {self.run_id} has completed successfully.", | ||
"run_id": self.run_id, | ||
} | ||
) | ||
elif job_run_status == DbtCloudJobRunStatus.CANCELLED.value: | ||
yield TriggerEvent( | ||
{ | ||
"status": "cancelled", | ||
"message": f"Job run {self.run_id} has been cancelled.", | ||
"run_id": self.run_id, | ||
} | ||
) | ||
else: | ||
yield TriggerEvent( | ||
{ | ||
"status": "error", | ||
"message": f"Job run {self.run_id} has failed.", | ||
"run_id": self.run_id, | ||
} | ||
) | ||
except Exception as e: | ||
yield TriggerEvent({"status": "error", "message": str(e), "run_id": self.run_id}) | ||
|
||
async def is_still_running(self, hook: DbtCloudHook) -> bool: | ||
""" | ||
Async function to check whether the job is submitted via async API is in | ||
running state and returns True if it is still running else | ||
return False | ||
""" | ||
job_run_status = await hook.get_job_status(self.run_id, self.account_id) | ||
if not DbtCloudJobRunStatus.is_terminal(job_run_status): | ||
return True | ||
return False |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with this wrapper (as well as other same decorators which already exists in community providers) that every time we access to method which decorated by this function we need to lookup for connection in Secrets Backend (if configured), Environment Variables and Airflow Database.
Is any way to make it cashable? Something like that: #28716
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will check if it can be made cacheable