Add deferrable mode to DbtCloudRunJobOperator
#29014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
reviewed
Jan 18, 2023
Comment on lines
+134
to
+139
| def provide_account_id(func: T) -> T: | ||
| """ | ||
| Decorator which provides a fallback value for ``account_id``. If the ``account_id`` is None or not passed | ||
| to the decorated function, the value will be taken from the configured dbt Cloud Airflow Connection. | ||
| """ | ||
| function_signature = signature(func) |
There was a problem hiding this comment.
The problem with this wrapper (as well as other same decorators which already exists in community providers) that every time we access to method which decorated by this function we need to lookup for connection in Secrets Backend (if configured), Environment Variables and Airflow Database.
Is any way to make it cashable? Something like that: #28716
There was a problem hiding this comment.
will check if it can be made cacheable
phanikumv
force-pushed
the
dbt_async
branch
3 times, most recently
from
165ea0c
to
834bb09
Compare
kaxil
reviewed
Jan 19, 2023
kaxil
approved these changes
Jan 23, 2023
josh-fell
added a commit
to josh-fell/airflow
that referenced
this pull request
Feb 2, 2023
Related: apache#28890 apache#29014 There was a recent enhancement of DbtCloudRunJobOperator to include deferrable/async functionality. Unfortunately the `tenant` evaluation in the DbtCloudHook was outdated and didn't include the most recent change to properly handle domain specification. This PR consolidates the tenant eval logic to a common method to be used by both sync and async methods in the hook.
josh-fell
added a commit
that referenced
this pull request
Feb 2, 2023
* Correct tenant eval within async logic of DbtCloudHook Related: #28890 #29014 There was a recent enhancement of DbtCloudRunJobOperator to include deferrable/async functionality. Unfortunately the `tenant` evaluation in the DbtCloudHook was outdated and didn't include the most recent change to properly handle domain specification. This PR consolidates the tenant eval logic to a common method to be used by both sync and async methods in the hook. * Remove Connection.schema use * Update provider.yaml and changelog
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR donates the
DbtCloudRunJobOperatorAsyncfrom astronomer-providers repo^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.