Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitnami/postgresql helm depenency from 10.5.3 to 12.1.9 #29071

Merged

Conversation

snjypl
Copy link
Contributor

@snjypl snjypl commented Jan 20, 2023

Fixes: #27353

this is a continuation of #27357. i fixed the failing unittests


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add the original author as co-author

@snjypl snjypl force-pushed the 27353-upgrade-postgresql-helm-chart-to-12.1.9 branch from 89da656 to 8119198 Compare January 20, 2023 20:30
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also verified the tarball came from bitnami.

@snjypl snjypl force-pushed the 27353-upgrade-postgresql-helm-chart-to-12.1.9 branch from 8119198 to 54e8588 Compare January 20, 2023 21:01
This version of the chart uses different variable names for setting usernames and passwords in the postgres database.
`postgresql.auth.enablePostgresUser` is used to determine if the "postgres" admin account will be created.
`postgresql.auth.postgresPassword` sets the password for the "postgres" user.
`postgresql.auth.username` and `postrgesql.auth.password` are used to set credentials for a non-admin account if desired.
`postgresql.postgresqlUsername` and `postgresql.postresqlPassword`, which were used in the previous version of the chart, are no longer used.
Users will need to change these variable names in their values files if they are using the helm chart.

Co-authored-by: Caleb Woofenden <caleb.woofenden@bitsighttech.com>
@snjypl snjypl force-pushed the 27353-upgrade-postgresql-helm-chart-to-12.1.9 branch from 54e8588 to 8b69b1c Compare January 20, 2023 23:56
@potiuk potiuk merged commit 5da085b into apache:main Jan 21, 2023
1 check passed
@snjypl snjypl deleted the 27353-upgrade-postgresql-helm-chart-to-12.1.9 branch January 21, 2023 05:36
maggesssss pushed a commit to maggesssss/airflow that referenced this pull request Jan 21, 2023
…he#29071)

This version of the chart uses different variable names for setting usernames and passwords in the postgres database.
`postgresql.auth.enablePostgresUser` is used to determine if the "postgres" admin account will be created.
`postgresql.auth.postgresPassword` sets the password for the "postgres" user.
`postgresql.auth.username` and `postrgesql.auth.password` are used to set credentials for a non-admin account if desired.
`postgresql.postgresqlUsername` and `postgresql.postresqlPassword`, which were used in the previous version of the chart, are no longer used.
Users will need to change these variable names in their values files if they are using the helm chart.

Co-authored-by: Caleb Woofenden <caleb.woofenden@bitsighttech.com>
jedcunningham added a commit to astronomer/airflow that referenced this pull request Jan 28, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:helm-chart Airflow Helm Chart changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to the latest version of bitnami/postgresql
4 participants