-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template extra volumes in helm chart #29357
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
dbf4361
to
c37d95f
Compare
@jedcunningham @dstandish what do you think about this feature ? I think it would be a valuable addition to make the chart more flexible. Many customers have different naming patterns in their K8S environment. |
I think this one needs documentation explaining usage of this feature. Otherwise it won't be discoverable. |
Fair point. I suggest to add a comment/example above the impacted fields in values.yaml (Not sure how many people actually read/use the schema.json file, I can image most of airflow admins check values.yaml first). For instance:
Would it be acceptable this way ? If so I will proceed with the changes |
I think we also need a small chapter in Production Guide: https://airflow.apache.org/docs/helm-chart/stable/production-guide.html with short explanation of the use case and why you would like to do it. |
My 2c, an example like @planoe suggested is enough. We can't put everything in the prod guide, it'd be way too long. We could consider documenting more advanced features, but we should do that as a separate effort I think. |
Fine for me. |
Sorry for the delay, I updated the comments. Hopefully it can be merged now |
There ere merge conflicts now after reformatting of the chart templates . Need to be fixed |
Thanks I fixed the merge conflicts. |
Awesome work, congrats on your first merged pull request! |
Thanks @planoe! Congrats on your first commit 🎉 |
Thank you, hopefully more to come soon :) |
This adds the possibility to define dynamic names (defined in custom helm template functions) for volumes and volumeMounts definitions such as secret names, config map names, mount paths etc.
I did not find a way to add tests in which I could define custom template functions, but I ran the chart tests successfully so it brings no regressions and I already use this in production, which works fine so far.