Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove airflow user from Dockerfile.ci (#31970)" #33419

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 15, 2023

This reverts commit a298874.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested a review from ashb as a code owner August 15, 2023 20:09
@potiuk potiuk requested a review from uranusjr August 15, 2023 20:09
@potiuk
Copy link
Member Author

potiuk commented Aug 15, 2023

It turned out that airflow user is useful for SSH debugging.

@potiuk
Copy link
Member Author

potiuk commented Aug 15, 2023

Following the slack conversation: https://apache-airflow.slack.com/archives/CQ9QHSFQX/p1692085262768459

@shahar1
Copy link
Collaborator

shahar1 commented Aug 15, 2023

It might be worth adding documentation of where/how it's being used to avoid (non-)accidental deletion for the next time I missed the comment, sorry :)

@potiuk potiuk force-pushed the bring-back-airflow-user-in-ci-image branch from 815576e to 5359ce2 Compare August 15, 2023 20:56
@potiuk
Copy link
Member Author

potiuk commented Aug 16, 2023

Merging for now - there is a discussion on how maybe we could leverage the "root" user for other kinds of debugging in slack https://apache-airflow.slack.com/archives/CQ9QHSFQX/p1692085262768459 but for now I will just bring back what's advertised.

@potiuk potiuk merged commit 86f9f95 into apache:main Aug 16, 2023
58 of 61 checks passed
@potiuk potiuk deleted the bring-back-airflow-user-in-ci-image branch August 16, 2023 06:30
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants