Remove the creation of airflow user from Dockerfile.ci#31970
Merged
potiuk merged 1 commit intoapache:mainfrom Jun 18, 2023
Merged
Remove the creation of airflow user from Dockerfile.ci#31970potiuk merged 1 commit intoapache:mainfrom
airflow user from Dockerfile.ci#31970potiuk merged 1 commit intoapache:mainfrom
Conversation
shahar1
changed the title
Dockerfile.ciairflow from Dockerfile.ci
shahar1
changed the title
airflow from Dockerfile.ciairflow user from Dockerfile.ci
potiuk
added
the
full tests needed
potiuk
force-pushed
the
remove-airflow-user-from-dockerfile-ci
branch
from
130d4d7 to
0d88699
Compare
Member
|
Set the "full tests needed" and rebased - to see if there is no missed tests. |
potiuk
force-pushed
the
remove-airflow-user-from-dockerfile-ci
branch
from
0d88699 to
c549fad
Compare
Member
|
All looks good :). Seems it was indeed a thing of a past. |
potiuk
approved these changes
Jun 18, 2023
Member
|
Ah... WE need to revert this one, It was actually used to enable ssh debugging. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 15, 2023
This reverts commit a298874.
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 17, 2023
…che#33419) This reverts commit a298874.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion #31714 - I'm trying to remove
airflowuser fromDockerfile.ciand see how it affects the tests.Edit: All the tests passed successfully, might be a good time to remove this code snippet.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.