Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state utils to Public Airflow Interface #34059

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 3, 2023

The state enums are likely to be used externally and they should not be changed in backwards-incompatible way.

Discussed in #33746


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a spelling error in the file _api/airflow/utils/state/index. Otherwise LGTM

The state enums are likely to be used externally and they should
not be changed in backwards-incompatible way.

Discussed in apache#33746
@potiuk potiuk force-pushed the add-state-to-public-interface branch from 0281cb9 to 0c32fde Compare September 3, 2023 21:34
@potiuk
Copy link
Member Author

potiuk commented Sep 3, 2023

Right :)

@uranusjr uranusjr merged commit c44e5b5 into apache:main Sep 4, 2023
42 checks passed
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.2 milestone Oct 3, 2023
@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Oct 3, 2023
ephraimbuddy pushed a commit that referenced this pull request Oct 5, 2023
@potiuk potiuk deleted the add-state-to-public-interface branch November 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants