Refactor: use stdlib's textwrap.shorten #34125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Sep 5, 2023
It also breaks the string at a word boundary. As I said, the output is not 100% identical, but hopefully better. And certainly easier to read as code. |
eumiro
force-pushed
the
textwrap-shorten
branch
from
d0c4844
to
11e6457
Compare
potiuk
approved these changes
Sep 7, 2023
potiuk
force-pushed
the
textwrap-shorten
branch
from
11e6457
to
0509a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a 100% equivalent refactoring, but should look better in the result.