Fixing status icon alignment for various views #36804
Conversation
amoghrajesh
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
|
@bbovenzi @pierrejeambrun can you help in a review here when you have some time? |
|
@bbovenzi can you take a look at this when you have some time? |
|
I don't think that manually translating by 2 px is the way to go, this is hacky. (That might not work on every browser, screen size etc...). Just using the flex property of the Box should be enough |
Thanks for your review, will try doing using flex |
|
@pierrejeambrun I made the changes using flex of Box, results look the same now: |
amoghrajesh
requested review from
kaxil,
potiuk,
jedcunningham,
eladkal,
o-nikolas,
hussein-awala,
Fokko,
josh-fell,
mik-laj,
ephraimbuddy,
dstandish,
bolkedebruin and
XD-DENG
as code owners
amoghrajesh
force-pushed
the
uiALignMent
branch
from
d12d628
to
4027a5d
Compare
amoghrajesh
removed request for
Fokko,
ephraimbuddy,
bolkedebruin,
kaxil,
XD-DENG,
mik-laj,
dstandish,
hussein-awala,
eladkal,
josh-fell,
o-nikolas and
jedcunningham
|
Oops, that was a bad rebase, removed all reviewers who got added due to it |
|
The failure seems related to #37093 |
* Fixing status icon alignment * review from pierre (cherry picked from commit 5407318)
* Fixing status icon alignment * review from pierre (cherry picked from commit 5407318)
* Fixing status icon alignment * review from pierre (cherry picked from commit 5407318)
* Fixing status icon alignment * review from pierre
In lines to #36574, there was a slight misalignment even in the status icon. Since
Boxprop doesn't accept the style argument, fixed it using thetranslateoption.Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.