Workaround backwards-incompatibility in google-core-api 2.16.0 #37093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a backwards-incompatible change in google.api_core.retry.AsyncRetry imports. In 2.16.0 version of google-api-core, AsyncRetry was moved to google.api_core.retry_unary_async and backwards compatibility impots were not haandling the case of: `from google.api_core.retry_async imprt AsyncRetry` The issue is tracked in googleapis/python-api-core#586 Until it is solved, we need to handle both cases, because one works before and one after 2.16.0. But there is no import that works for both.
boring-cyborg
bot
added
area:providers
area:system-tests
provider:google
potiuk
deleted the
workaround-google-core-api-backwards-incompatibility-issue
branch
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
…e#37093) There is a backwards-incompatible change in google.api_core.retry.AsyncRetry imports. In 2.16.0 version of google-api-core, AsyncRetry was moved to google.api_core.retry_unary_async and backwards compatibility impots were not haandling the case of: `from google.api_core.retry_async imprt AsyncRetry` The issue is tracked in googleapis/python-api-core#586 Until it is solved, we need to handle both cases, because one works before and one after 2.16.0. But there is no import that works for both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a backwards-incompatible change in
google.api_core.retry.AsyncRetry imports.
In 2.16.0 version of google-api-core, AsyncRetry was moved to google.api_core.retry_unary_async and backwards compatibility impots were not haandling the case of:
from google.api_core.retry_async imprt AsyncRetryThe issue is tracked in googleapis/python-api-core#586
Until it is solved, we need to handle both cases, because one works before and one after 2.16.0.
But there is no import that works for both.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.