Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve task names in graph view #37254

Merged
merged 1 commit into from Feb 9, 2024

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Feb 8, 2024

  • Make longer node for tasks with long names.
  • Use TaskName component between grid and graph view with consistent icons for task groups and setup/teardown
  • Adjust position of zoomed out nodes to support two rows of task name text

Before:
Screenshot 2024-02-08 at 12 32 38 PM
Screenshot 2024-02-08 at 12 32 53 PM
Screenshot 2024-02-08 at 12 33 07 PM
Screenshot 2024-02-08 at 12 33 04 PM

After:
Screenshot 2024-02-08 at 12 32 11 PM
Screenshot 2024-02-08 at 12 32 04 PM
Screenshot 2024-02-08 at 12 31 55 PM
Screenshot 2024-02-08 at 12 31 51 PM
Screenshot 2024-02-08 at 12 31 42 PM


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 8, 2024
@bbovenzi bbovenzi added this to the Airflow 2.8.2 milestone Feb 8, 2024
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! that was one of the complains of a few people who cried "I want the old view back" !

@eladkal eladkal merged commit 9b99763 into apache:main Feb 9, 2024
54 checks passed
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Feb 9, 2024
@bbovenzi bbovenzi deleted the more-graph-node-improvements branch February 9, 2024 16:58
jedcunningham pushed a commit that referenced this pull request Feb 9, 2024
potiuk pushed a commit that referenced this pull request Feb 13, 2024
sunank200 pushed a commit to astronomer/airflow that referenced this pull request Feb 21, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants