Change margin to padding so first task can be selected #37527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchiapaikeo
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:UI
hussein-awala
approved these changes
Feb 19, 2024
dirrao
approved these changes
Feb 20, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 20, 2024
(cherry picked from commit 7b422be)
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 20, 2024
(cherry picked from commit 7b422be)
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
Feb 21, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 7b422be)
68 tasks
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, selecting the first task is difficult due to additional margin from the TaskName refactor that covers it up. You can see this in this screenshot:
ui-nits.mov
You can see the p tag nested within the td element has margins that extend past td.
Change this to padding instead so the first task is selectable.
Before:
After:
cc @bbovenzi
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.