remove duplicate ports key in webserver-service.yaml

[Ahmad-RW]

remove duplicate key in webserver service template

---

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[brokenjacobs]

Just an FYI these duplicate ports break installation with fluxcd... So you can do a manual helm install but you can't use fluxcd to deploy in the cluster because the yaml is broken. Please please please cut a new helm chart release @potiuk !

[jedcunningham]

Let's sit on it for a little bit longer to see if anything else shakes out. I'm happy to start a new release later this week. That said, it'd be great if you all could test the RCs so we can find these accidental regressions before the release is finalized.

[tsgit]

apart from the duplicate ports: the whitespace changes following that in the generated yaml are also odd.
$ helm template airflow apache-airflow/airflow -f values.yaml --namespace=$(NAMESPACE)
gives

    component: webserver
    release: airflow
  ports:
  ports:
  
    -
      name: airflow-ui
      port: 8080

in addition I see a duplicate
cluster-autoscaler.kubernetes.io/safe-to-evict: "true" in the airflow-scheduler deployment section of the rendered chart

likely due to

https://github.com/apache/airflow/blob/main/chart/templates/scheduler/scheduler-deployment.yaml#L98-L106

when using the kustomize HelmChartInflationGenerator this results in error

error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 47: mapping key "cluster-autoscaler.kubernetes.io/safe-to-evict" already defined at line 46

I believe the worker-deployment template avoids this via
https://github.com/apache/airflow/blob/main/chart/templates/workers/worker-deployment.yaml#L41-L42

[brokenjacobs]

Let's sit on it for a little bit longer to see if anything else shakes out. I'm happy to start a new release later this week. That said, it'd be great if you all could test the RCs so we can find these accidental regressions before the release is finalized.

Heard. Is there an RC for this one?

[jedcunningham]

Not yet. It'll be an RC containing everything that'll be in the next release. It'll be announced on the devlist (instructions to join).

[jabbera]

I've got a need for this as well. I can't use kustomize without this fix.

[BalaMuralibi]

@jedcunningham I ran into same error with ports to install with flux, We can't do manual install. Any ETA when is the chart 1.12.0 is expected to be updated ?

[potiuk]

I believe we will do it after we release Airlfow 2.8.2. But I think it realy depends on how much time people like you will spend on testing the RCs when they are out - apparrently you missed the announcement on RC 1.12.0 to catch this earlier. Can we count on you helping testing it when RC is out @BalaMuralibi ? It requires you to subscribe to our devlist https://airflow.apache.org/community/ and when we ask people to test RC - you should respond and confirm that it is fixed.

Can we count on you @BalaMuralibi ?

Subscribing to devlist is the way when you can find out when RC is out. In the meantime, there is absolutely no problem to use the previous helm chart, I think.

[potiuk]

Also @jabbera - you can still use previous version and subscribe to devlist and when we ask you to test RC, we'd expect you test it and confirm it works. You seem to be very interested to get it - so it looks like you would be interested in helping out to test the RC when it is out. That will definitely speed up and improve the release if people like @BalaMuralibi and @jabbera who are early adopters will test the RCs. Can we count on the both of you to help with RCs?

[potiuk]

@brokenjacobs -> you as well. Please subscribe to our devlist and when RC is out, please verify and test if it works for you and respond to our requests to test the RC when it is out. In the meantime any of you can either use the previous version, or - if you are adventurous, you can also install current main version - you will find chart/INSTALL with instructions how to install chart from main after checking out the main version of the repo.

I think doing this kind of preliminary testing and reporting back the status of it is absolutely best way to make such release faster, so if you care about getting new release faster, this is precisely the way you can help with. It works much better than asking for ETA on that.

[BalaMuralibi]

I believe we will do it after we release Airlfow 2.8.2. But I think it realy depends on how much time people like you will spend on testing the RCs when they are out - apparrently you missed the announcement on RC 1.12.0 to catch this earlier. Can we count on you helping testing it when RC is out @BalaMuralibi ? It requires you to subscribe to our devlist https://airflow.apache.org/community/ and when we ask people to test RC - you should respond and confirm that it is fixed.

Can we count on you @BalaMuralibi ?

Subscribing to devlist is the way when you can find out when RC is out. In the meantime, there is absolutely no problem to use the previous helm chart, I think.

sure, I can test rc when it is out.

[jedcunningham]

I believe we will do it after we release Airlfow 2.8.2.

Yep, that's exactly my plan.