Mapping key "cluster-autoscaler.kubernetes.io/safe-to-evict" already defined

[nuvme-devops]

Official Helm Chart version

1.13.0 (latest released)

Apache Airflow version

2.8

Kubernetes Version

2.8.2

Helm Chart configuration

apiVersion: helm.toolkit.fluxcd.io/v2beta2
kind: HelmRelease
metadata:
  name: airflow
  namespace: airflow
spec:
  interval: 5m
  chart:
    spec:
      version: 1.13.0
      chart: airflow
      sourceRef:
        kind: HelmRepository
        name: airflow-charts
        namespace: flux-system
      interval: 1m
  values:
    createUserJob:
      useHelmHooks: false
      applyCustomEnv: false
    migrateDatabaseJob:
      useHelmHooks: false
      applyCustomEnv: false
    useStandardNaming: true 

Docker Image customizations

No response

What happened

I get the error below when deploying Flux with version 1.13.0.

Helm install failed for release airflow/airflow with chart
        airflow@1.13.0: error while running post render on files:
        map[string]interface {}(nil): yaml: unmarshal errors:
          line 45: mapping key "cluster-autoscaler.kubernetes.io/safe-to-evict" already defined at line 44

In version 1.11.0 everything works fine, and in version 1.12.0 we get the same error but for "ports"

Without Flux, we have no problems with version 1.13.0, but I noticed something similar in version 1.12.0.
#37356

What you think should happen instead

No response

How to reproduce

Flux helm-controller:v0.37.4

apiVersion: helm.toolkit.fluxcd.io/v2beta2
kind: HelmRelease
metadata:
  name: airflow
  namespace: airflow
spec:
  interval: 5m
  chart:
    spec:
      version: 1.13.0
      chart: airflow
      sourceRef:
        kind: HelmRepository
        name: airflow-charts
        namespace: flux-system
      interval: 1m
  values:
    createUserJob:
      useHelmHooks: false
      applyCustomEnv: false
    migrateDatabaseJob:
      useHelmHooks: false
      applyCustomEnv: false
    useStandardNaming: true 

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[nuvme-devops]

Update:
We succeeded in the installation using the values below:

    workers:
      safeToEvict: false
    scheduler:
      safeToEvict: false
    triggerer:
      safeToEvict: false
    dagProcessor:
      safeToEvict: false
    redis:
      safeToEvict: false

[hussein-awala]

I wonder if you have a webhook or Flux Kustomization (for ex) that patches your deployments to add the safe to evict label.

[nuvme-devops]

Hi @hussein-awala not yet, I'm researching it now.

[jrderuiter]

This also happens in a vanilla build of the helm chart using kustomize, so I don't think it's related to @nuvme-devops setup.

You can reproduce this by creating the following kustomization.yml:

# kustomization.yml

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

namespace: airflow

helmCharts:
- name: airflow
  releaseName: airflow
  version: "1.13.0"
  repo: https://airflow.apache.org

And trying to build the template using kustomize with --enable-helm:

kustomize build --enable-helm .

Which gives the following error:

Error: map[string]interface {}(nil): yaml: unmarshal errors:
  line 44: mapping key "cluster-autoscaler.kubernetes.io/safe-to-evict" already defined at line 43

This indicates that the generated templates are invalid due to this duplicate key (which is maybe not checked in other contexts). The workaround @nuvme-devops works here as well, probably by avoiding those labels entirely.

[sgrzemski]

It has nothing to do with flux. When I template the helm locally the annotations are doubled. Same goes for podAnnotations in each of the components.

[hussein-awala]

I cannot reproduce it on the main branch, the issue was fixed by #37917 just after releasing 1.13.0.

@jedcunningham it's worth a patch release.

[hussein-awala]

We will release a patch version in the coming days, I am closing the issue as fixed by #37917.

I recommend testing the RC version once it is released to make sure the version fixes your issue.