Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rest API logging #37581

Closed
wants to merge 3 commits into from
Closed

Fix rest API logging #37581

wants to merge 3 commits into from

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented Feb 21, 2024

Part of #22352

Try to improve action logging in the REST API. Include api.{name_of_function}. We should probably try to capture more information for extra but audit log now reads like so:

Screenshot 2024-02-20 at 11 15 15 PM

This is a draft to get feedback on the format and then I will do it for basically all PATCH, PUT, POST, DELETE endpoints


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bbovenzi bbovenzi added this to the Airflow 2.9.0 milestone Feb 21, 2024
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Feb 21, 2024
@vincbeck
Copy link
Contributor

LGTM

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbovenzi
Copy link
Contributor Author

Made extra a json object instead of a tuple. Added request body to extra. And hiding sensitive fields for connections and variables:

Screenshot 2024-02-21 at 9 49 41 PM

@jscheffl
Copy link
Contributor

Looks good for me!

@bbovenzi
Copy link
Contributor Author

Closing in favor of #37734

I want to leave changes to variables+connections API and the extra field as a separate effort

@bbovenzi bbovenzi closed this Feb 27, 2024
@ephraimbuddy ephraimbuddy removed this from the Airflow 2.8.3 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants