Add REST API events to Audit Log #37734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ryanahamilton,
ashb,
pierrejeambrun,
ephraimbuddy,
potiuk,
kaxil and
XD-DENG
as code owners
boring-cyborg
bot
added
area:API
Closed
airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py
Outdated
Show resolved
Hide resolved
airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py
Outdated
Show resolved
Hide resolved
bbovenzi
changed the title
jscheffl
approved these changes
Feb 29, 2024
airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
audit-rest-api-crud
branch
2 times, most recently
from
07e54dc
to
68a655a
Compare
|
@bbovenzi |
Lee-W
force-pushed
the
audit-rest-api-crud
branch
2 times, most recently
from
96419d8
to
77249b2
Compare
…ng_size.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
bbovenzi
force-pushed
the
audit-rest-api-crud
branch
from
77249b2
to
8c258be
Compare
jedcunningham
approved these changes
Mar 7, 2024
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
howardyoo
pushed a commit
to howardyoo/airflow
that referenced
this pull request
Mar 18, 2024
* Fix rest API logging * Interpret ui/api & func name, format extra as json * Fix secret check * Add action logging and tests for crud endpoints * Check correct task instance in setNote test * Update airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * fix mypy * fix: remove package.json and package-lock.json which seems to be accidentally added * fix mypy * Merge Log migration files * rename migration * try fix mypy? * Add news fragment * Update newsfragments/37734.significant.rst Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com>
howardyoo
pushed a commit
to howardyoo/airflow
that referenced
this pull request
Mar 31, 2024
* Fix rest API logging * Interpret ui/api & func name, format extra as json * Fix secret check * Add action logging and tests for crud endpoints * Check correct task instance in setNote test * Update airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * fix mypy * fix: remove package.json and package-lock.json which seems to be accidentally added * fix mypy * Merge Log migration files * rename migration * try fix mypy? * Add news fragment * Update newsfragments/37734.significant.rst Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com>
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
* Fix rest API logging * Interpret ui/api & func name, format extra as json * Fix secret check * Add action logging and tests for crud endpoints * Check correct task instance in setNote test * Update airflow/migrations/versions/0134_2_9_0_increase_log_event_string_size.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * fix mypy * fix: remove package.json and package-lock.json which seems to be accidentally added * fix mypy * Merge Log migration files * rename migration * try fix mypy? * Add news fragment * Update newsfragments/37734.significant.rst Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22352
Add logging to all CRUD REST API endpoints. In the
action_loggingdecorator, include checks for the url and origin to also distinguish between API endpoints from the Airflow UI vs externally.api.{name_of_function}orui.{name_of_function}^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.