Session is not used in _do_render_template_fields #37856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used so, we should be able to remove it. The context here is AIP-44 -- it's important to identify which functions require database access and which don't.
dirrao
suggested changes
Mar 3, 2024
ephraimbuddy
approved these changes
Mar 3, 2024
|
i found one more place where session was being passed. in case you are curious, we have not used session (at least not directly) in this method since this change: just want to double check with @uranusjr --- any reason not to merge this PR? |
|
I don’t quite recall why we removed the |
uranusjr
approved these changes
Mar 4, 2024
abhishekbhakat
pushed a commit
to abhishekbhakat/my_airflow
that referenced
this pull request
Mar 5, 2024
It's not used so, we should be able to remove it. The context here is AIP-44 -- it's important to identify which functions require database access and which don't. For reference, session has not been used in this function since apache@5d1270c#diff-f373d874912ccfa03918e853ad15aa91d6bfaa1ee75f1676f78c8a756f332ed0L351.
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
It's not used so, we should be able to remove it. The context here is AIP-44 -- it's important to identify which functions require database access and which don't. For reference, session has not been used in this function since apache@5d1270c#diff-f373d874912ccfa03918e853ad15aa91d6bfaa1ee75f1676f78c8a756f332ed0L351.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not used so, we should be able to remove it. The context here is AIP-44 -- it's important to identify which functions require database access and which don't.