Don't overwrite .Values.airflowPodAnnotations #37917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brokenjacobs
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
potiuk
approved these changes
Mar 5, 2024
2 tasks
3 tasks
utkarsharma2
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #37872
This PR should fix the worker deployment breaking the helm chart install with default values, and breaking any pod annotations added to other deployments in the chart. Without the deepCopy the mergeOverwrite in the workers deployment sets every deployment to use the same annotations as the worker, leading to duplicate keys.
As is, the existing helm chart won't install on a cluster. We need better CI processes for the helm chart.