Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing the aws executors with a shorter path #39093

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

o-nikolas
Copy link
Contributor

@o-nikolas o-nikolas commented Apr 17, 2024

Import the aws executors in the __init__.py module of their respective directories so that they can be imported with a shorter and more natural looking module path.

For example, this modules path:

airflow.providers.amazon.aws.executors.batch.batch_executor.AwsBatchExecutor

Becomes:

airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor

fixes #38524


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Import the aws executors in the __init__.py module of their
respective directories so that they can be imported with a shorter and
more natural looking module path.

For example, this modules path:

`airflow.providers.amazon.aws.executors.batch.batch_executor.AwsBatchExecutor`

Becomes:

`airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor`
@o-nikolas o-nikolas requested a review from eladkal as a code owner April 17, 2024 17:56
@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Apr 17, 2024
Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's worth to add unit test with shorter path.

@Taragolis
Copy link
Contributor

Just an idea, maybe move it into the package root and make it lazy-loaded thought PEP-562, e.g. the same way as if does into the:

@o-nikolas o-nikolas merged commit 4b9b400 into apache:main Apr 18, 2024
41 checks passed
@o-nikolas o-nikolas deleted the onikolas/aws_executors_module_path branch April 18, 2024 22:26
utkarsharma2 pushed a commit to astronomer/airflow that referenced this pull request Apr 22, 2024
* Allow importing the aws executors with a shorter path

Import the aws executors in the __init__.py module of their
respective directories so that they can be imported with a shorter and
more natural looking module path.

For example, this modules path:

`airflow.providers.amazon.aws.executors.batch.batch_executor.AwsBatchExecutor`

Becomes:

`airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor`
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this pull request May 10, 2024
* Allow importing the aws executors with a shorter path

Import the aws executors in the __init__.py module of their
respective directories so that they can be imported with a shorter and
more natural looking module path.

For example, this modules path:

`airflow.providers.amazon.aws.executors.batch.batch_executor.AwsBatchExecutor`

Becomes:

`airflow.providers.amazon.aws.executors.batch.AwsBatchExecutor`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants