Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow importing the aws executors with a shorter path #39093

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Allow importing the aws executors with a shorter path #39093

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d21301
Allow importing the aws executors with a shorter path
o-nikolas Apr 17, 2024
9da925e
Add comments to explain precommit shenanigans
o-nikolas Apr 17, 2024
10872c5
Reformat to make sphinx happy
o-nikolas Apr 17, 2024
6f43d9d
Add tests for short import path
o-nikolas Apr 18, 2024
825b7d7
Implement using __all__
o-nikolas Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions airflow/providers/amazon/aws/executors/batch/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,11 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations # Added by precommit hooks

from airflow.providers.amazon.aws.executors.batch.batch_executor import AwsBatchExecutor

# precommit hooks (rust as of the time of commit) throws F401 - "Module imported but unused"
# One of the solutions it suggests is using a "redundant alias". This is used below instead of doing a #no-qa
# type ignore of the issue.
AwsBatchExecutor = AwsBatchExecutor
o-nikolas marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 8 additions & 0 deletions airflow/providers/amazon/aws/executors/ecs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,11 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations # Added by precommit hooks

from airflow.providers.amazon.aws.executors.ecs.ecs_executor import AwsEcsExecutor

# precommit hooks (rust as of the time of commit) throws F401 - "Module imported but unused"
# One of the solutions it suggests is using a "redundant alias". This is used below instead of doing a #no-qa
# type ignore of the issue.
AwsEcsExecutor = AwsEcsExecutor