Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #33647
As mentioned by @arunravimv in #33647, we have added this patch to our own Airflow deployment and have noticed improvements in triggerer performance.
Following are the
Explain Analyze
outputs for the two SQL Alchemy relationship loading strategiesTriggerer Process
Using
joinedload
in bulk_fetch methodUsing
selectinload
in bulk_fetch methodtriggerview/list API
Using
joined
for relationship between TaskInstance and TriggerUsing
selectin
for relationship between TaskInstance and TriggerFrom above
Explain Analyze
results, we can see that usingselectinload
is gives more optimal performance for triggerer process as well as the triggerview list api.