Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change conf property from str to dict in SparkSqlOperator #40527

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

duhizjame
Copy link

Changes the conf property from str to dict in SparkSqlOperator
closes: #40507


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jul 1, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@duhizjame duhizjame force-pushed the SparkSqlOperator_uses_string_for_conf_instead_of_dict branch from bf84ccc to 030480d Compare July 2, 2024 07:28
@potiuk
Copy link
Member

potiuk commented Jul 2, 2024

Tests failing

@duhizjame duhizjame force-pushed the SparkSqlOperator_uses_string_for_conf_instead_of_dict branch from 030480d to 921f856 Compare July 3, 2024 11:47
@duhizjame duhizjame force-pushed the SparkSqlOperator_uses_string_for_conf_instead_of_dict branch from c520c4b to 5b336ab Compare July 11, 2024 13:00
@eladkal
Copy link
Contributor

eladkal commented Jul 21, 2024

Can you resolve conflicts and rebase?

Copy link

github-actions bot commented Sep 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:documentation provider:apache-spark stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SparkSqlOperator and SparkSubmitOperator are using different types for configurations
3 participants