-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3502] Add celery config option for setting "pool" #4308
Conversation
65442aa
to
dc3ac65
Compare
@gsilk - Should this be tagged with AIRFLOW-3502 ("Add config option to control celery pool used" instead of AIRFLOW-3501 ("Add config option to load dags in an image with the kubernetes executor.")? |
dc3ac65
to
4245ce6
Compare
Thanks for catching that, I've updated the PR |
lgtm, thanks @gsilk . will commit once ci is clear. |
Codecov Report
@@ Coverage Diff @@
## master #4308 +/- ##
==========================================
- Coverage 78.1% 78.09% -0.01%
==========================================
Files 201 201
Lines 16464 16466 +2
==========================================
Hits 12859 12859
- Misses 3605 3607 +2
Continue to review full report at Codecov.
|
… Celery pool implementation The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users.
(cherry picked from commit 96b8db6)
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3)
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users.
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users.
(cherry picked from commit 96b8db6)
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3)
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6) GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
… Celery pool implementation (#5477) The support to different Celery pool implementation has been added in apache/airflow#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
Make sure you have checked all steps below.
Jira
Description
Basically, this just adds a config option to the "celery" config for setting the "pool", which defaults to "prefork", but some users may want to use "solo" or other options.
Tests
This is a fairly simple change. Also, I'm not sure how to test it.
Commits
Documentation
Code Quality
flake8