Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3502] Add celery config option for setting "pool" #4308

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

gsilk
Copy link

@gsilk gsilk commented Dec 12, 2018

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Basically, this just adds a config option to the "celery" config for setting the "pool", which defaults to "prefork", but some users may want to use "solo" or other options.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

This is a fairly simple change. Also, I'm not sure how to test it.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

@kppullin
Copy link
Contributor

@gsilk - Should this be tagged with AIRFLOW-3502 ("Add config option to control celery pool used" instead of AIRFLOW-3501 ("Add config option to load dags in an image with the kubernetes executor.")?

@gsilk gsilk changed the title [AIRFLOW-3501] Add celery config option for setting "pool" [AIRFLOW-3502] Add celery config option for setting "pool" Dec 12, 2018
@gsilk
Copy link
Author

gsilk commented Dec 12, 2018

Thanks for catching that, I've updated the PR

@feng-tao
Copy link
Member

lgtm, thanks @gsilk . will commit once ci is clear.

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #4308 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
- Coverage    78.1%   78.09%   -0.01%     
==========================================
  Files         201      201              
  Lines       16464    16466       +2     
==========================================
  Hits        12859    12859              
- Misses       3605     3607       +2
Impacted Files Coverage Δ
airflow/bin/cli.py 64.43% <0%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e355c...4245ce6. Read the comment docs.

@feng-tao feng-tao merged commit 96b8db6 into apache:master Dec 12, 2018
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
XD-DENG added a commit to XD-DENG/airflow that referenced this pull request Jun 25, 2019
… Celery pool implementation

The support to different Celery pool implementation has been added
in apache#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.
ashb pushed a commit that referenced this pull request Jun 26, 2019
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in #4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.
ashb pushed a commit to ashb/airflow that referenced this pull request Jun 26, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Jun 26, 2019
… Celery pool implementation (apache#5477)

The support to different Celery pool implementation has been added
in apache#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3)
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
… Celery pool implementation (apache#5477)

The support to different Celery pool implementation has been added
in apache#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
… Celery pool implementation (apache#5477)

The support to different Celery pool implementation has been added
in apache#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
… Celery pool implementation (apache#5477)

The support to different Celery pool implementation has been added
in apache#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3)
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 7, 2020
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 11, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 18, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 22, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 23, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 24, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 2, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 7, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 9, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 10, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

(cherry picked from commit dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6)

GitOrigin-RevId: f6f37f207aadcbc31a66f045f92ea448df094da7
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 25, 2021
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 2, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 6, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 8, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 26, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 3, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
… Celery pool implementation (#5477)

The support to different Celery pool implementation has been added
in apache/airflow#4308.

But it's not reflected in the default_airflow.cfg yet, while it's
the main portal of config options to most users.

GitOrigin-RevId: dd08ae3469a50a145f9ae7f819ed1840fe2a5bd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants