[AIRFLOW-4847] Update config template to reflect supporting different Celery pool implementation#5477
Merged
Merged
Conversation
… Celery pool implementation The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users.
kaxil
reviewed
Jun 25, 2019
| ### `pool` config option in Celery section to support different Celery pool implementation | ||
|
|
||
| The new `pool` config option allows users to choose different pool | ||
| implementation. Default value is "prefork", while choices include "prefok" (default), |
Member
There was a problem hiding this comment.
Suggested change
| implementation. Default value is "prefork", while choices include "prefok" (default), | |
| implementation. Default value is "prefork", while choices include "prefork" (default), |
Member
Author
|
Typo is addressed. Thanks @kaxil ! |
Codecov Report
@@ Coverage Diff @@
## master #5477 +/- ##
=======================================
Coverage 79.11% 79.11%
=======================================
Files 489 489
Lines 30682 30682
=======================================
Hits 24275 24275
Misses 6407 6407Continue to review full report at Codecov.
|
feng-tao
approved these changes
Jun 25, 2019
Member
Author
|
@OmerJog unfortunately that's the best I can find in Celery's documentation. Actually they are enough from my point of view. Users are supposed to change this config only given they understand the differences, which can not really be covered by one or two links, and they should do their research. |
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Jun 26, 2019
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3)
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users.
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users.
dharamsk
pushed a commit
to postmates/airflow
that referenced
this pull request
Aug 8, 2019
… Celery pool implementation (apache#5477) The support to different Celery pool implementation has been added in apache#4308. But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. (cherry picked from commit dd08ae3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
Description
The support to different Celery pool implementation has been added in #4308 (https://github.com/apache/airflow/blob/master/airflow/bin/cli.py#L1086-L1087).
But it's not reflected in the default_airflow.cfg yet, while it's the main portal of config options to most users. Currently the only way for users to get to know the existence of this option is to check source code of
bin/cli.py(like what I have done).This situation can be addressed by adding it into
default_airflow.cfgand mentioning this change inUPDATING.md.