[AIRFLOW-3709] Validate allowed_states for ExternalTaskSensor
#4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ExternalTaskSensor, we can specify `allowed_states`. This commit adds validation for it, so that users will not specify any invalid state. This change works no matter the sensor waits for a DAG or a specific task.
Codecov Report
@@ Coverage Diff @@
## master #4536 +/- ##
==========================================
+ Coverage 74.02% 74.02% +<.01%
==========================================
Files 421 421
Lines 27644 27649 +5
==========================================
+ Hits 20463 20467 +4
- Misses 7181 7182 +1
Continue to review full report at Codecov.
|
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Mar 5, 2019
…he#4536) In ExternalTaskSensor, we can specify `allowed_states`. This commit adds validation for it, so that users will not specify any invalid state. This change works no matter the sensor waits for a DAG or a specific task.
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…he#4536) In ExternalTaskSensor, we can specify `allowed_states`. This commit adds validation for it, so that users will not specify any invalid state. This change works no matter the sensor waits for a DAG or a specific task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
In
ExternalTaskSensor, we can specifyallowed_states. This commit adds validation for it, so that users will not specify any invalid state (by accident).This change works no matter the sensor waits for a DAG (available since 2a8c91b) or a specific task.
Tests
Tests are added.