-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3887] Downgrade dagre-d3 to 0.4.18 #4713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagre-d3 v0.6.3 has a bug that causes this Javascript error when loading the Graph View: TypeError: previousPaths.merge is not a function The bug fix [1] has been merged to master, but hasn't been released to npm yet. This change temporarily downgrades our version of dagre-d3 until dagre-d3 v0.6.4 is released [2] I also fixed a bug I encountered in the `compile_assets.sh` where the script would fail if the directory `airflow/www/static/dist/` exists but is empty. [1] dagrejs/dagre-d3#350 [2] https://github.com/dagrejs/dagre-d3/blob/5450627790ff42012ef50cef6b0e220199ae4fbe/package.json#L3
cc @feng-tao |
LGTM |
astahlman
added a commit
to lyft/airflow
that referenced
this pull request
Feb 15, 2019
Pulling in fix for dagre-d3 errors in the UI [1] [1] apache#4713
5 tasks
antonimaciej
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Feb 26, 2019
dagre-d3 v0.6.3 has a bug that causes this Javascript error when loading the Graph View: TypeError: previousPaths.merge is not a function The bug fix [1] has been merged to master, but hasn't been released to npm yet. This change temporarily downgrades our version of dagre-d3 until dagre-d3 v0.6.4 is released [2] I also fixed a bug I encountered in the `compile_assets.sh` where the script would fail if the directory `airflow/www/static/dist/` exists but is empty. [1] dagrejs/dagre-d3#350 [2] https://github.com/dagrejs/dagre-d3/blob/5450627790ff42012ef50cef6b0e220199ae4fbe/package.json#L3
ashb
pushed a commit
that referenced
this pull request
Apr 3, 2019
dagre-d3 v0.6.3 has a bug that causes this Javascript error when loading the Graph View: TypeError: previousPaths.merge is not a function The bug fix [1] has been merged to master, but hasn't been released to npm yet. This change temporarily downgrades our version of dagre-d3 until dagre-d3 v0.6.4 is released [2] I also fixed a bug I encountered in the `compile_assets.sh` where the script would fail if the directory `airflow/www/static/dist/` exists but is empty. [1] dagrejs/dagre-d3#350 [2] https://github.com/dagrejs/dagre-d3/blob/5450627790ff42012ef50cef6b0e220199ae4fbe/package.json#L3
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
dagre-d3 v0.6.3 has a bug that causes this Javascript error when loading the Graph View: TypeError: previousPaths.merge is not a function The bug fix [1] has been merged to master, but hasn't been released to npm yet. This change temporarily downgrades our version of dagre-d3 until dagre-d3 v0.6.4 is released [2] I also fixed a bug I encountered in the `compile_assets.sh` where the script would fail if the directory `airflow/www/static/dist/` exists but is empty. [1] dagrejs/dagre-d3#350 [2] https://github.com/dagrejs/dagre-d3/blob/5450627790ff42012ef50cef6b0e220199ae4fbe/package.json#L3
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
dagre-d3 v0.6.3 has a bug that causes this Javascript error when loading
the Graph View:
The bug fix [1] has been merged to master, but hasn't been released to
npm yet. This change temporarily downgrades our version of dagre-d3
until dagre-d3 v0.6.4 is released [2]
I also fixed a bug I encountered in the
compile_assets.sh
where thescript would fail if the directory
airflow/www/static/dist/
exists butis empty.
[1] dagrejs/dagre-d3#350
[2] https://github.com/dagrejs/dagre-d3/blob/5450627790ff42012ef50cef6b0e220199ae4fbe/package.json#L3
Tests
Commits
Documentation
Code Quality
flake8