[AIRFLOW-3767] Correct bulk insert function #4773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongjiajie
force-pushed
the
fix_oracle_hook_bulk_insert_field_error
branch
2 times, most recently
from
8b50dc7
to
ed239f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4773 +/- ##
=========================================
+ Coverage 74.33% 74.44% +0.1%
=========================================
Files 450 450
Lines 28970 28972 +2
=========================================
+ Hits 21536 21569 +33
+ Misses 7434 7403 -31
Continue to review full report at Codecov.
|
Fokko
reviewed
Feb 27, 2019
airflow/hooks/oracle_hook.py
Outdated
| values = ', '.join(':%s' % i for i in range(1, len(target_fields) + 1)) | ||
| prepared_stm = 'insert into {tablename} ({columns}) values ({values})'.format( | ||
| if target_fields: | ||
| columns = ', '.join(target_fields) |
There was a problem hiding this comment.
Maybe move this directly inside of the format? or give it a different name, I don't like overwriting variables :-)
There was a problem hiding this comment.
@Fokko Change the code as you said, waiting for CI pass, PTAL.
Fix Oracle hook bulk_insert bug when param target_fields is None or rows is empty iterable
zhongjiajie
force-pushed
the
fix_oracle_hook_bulk_insert_field_error
branch
3 times, most recently
from
efc1141
to
125b411
Compare
|
CI test failed many many many time for no detaile resone 😭 😭 😭 |
zhongjiajie
force-pushed
the
fix_oracle_hook_bulk_insert_field_error
branch
from
125b411
to
0a3f460
Compare
|
CI pass finally |
|
The CI is currently super flaky 😭 |
|
Thanks @Fokko |
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2019
* [AIRFLOW-3767] Correct bulk insert function Fix Oracle hook bulk_insert bug when param target_fields is None or rows is empty iterable * change without overwriting variables as Fokko said
andriisoldatenko
pushed a commit
to andriisoldatenko/airflow
that referenced
this pull request
Jul 26, 2019
* [AIRFLOW-3767] Correct bulk insert function Fix Oracle hook bulk_insert bug when param target_fields is None or rows is empty iterable * change without overwriting variables as Fokko said
wmorris75
pushed a commit
to modmed/incubator-airflow
that referenced
this pull request
Jul 29, 2019
* [AIRFLOW-3767] Correct bulk insert function Fix Oracle hook bulk_insert bug when param target_fields is None or rows is empty iterable * change without overwriting variables as Fokko said
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Oracle hook bulk_insert bug when
target_fieldsis None orrowsisempty iterable
Make sure you have checked all steps below.
Jira
Description
Fix Oracle_hook bulk_insert_rows while param
target_fieldsis None androwsis empty iterable.Tests
test/hooks/test_oracle_hook.pyfunctiontest_bulk_insert_rows_without_fieldsandtest_bulk_insert_rows_no_rowsCommits
Documentation
Code Quality
flake8