Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5148] Add Google Analytics to the Airflow doc website #5817

Closed
wants to merge 1 commit into from

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Aug 14, 2019

The discussion begins in PR: #5763


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

The previous PR #5763 has been merged and reverted, so I create PR again with the same change to discuss it. Any comment on PR #5763 sends an email to all the committers across all Apache projects, so please do not comment. @kaxil have locked down the conversation but that would still allow anyone with write access to the repo to be able to comment on it.

Note from @kaxil:

Asked by @aijamalnk

Note from her:

I've looked at Google Analytics for the Airflow site, and I noticed that:
-The https://airflow.readthedocs.io/en/latest/ site has the GA code set up.

  • The https://airflow.apache.org site does NOT have the GA code set up.
    So the data that we're getting on GA is not complete.
    It would be really helpful to fix it soon, before we start revamping the website to understand the changes user behavior (I am signing a contract with a vendor next week)

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj changed the title [AIRFLOW-5148] Add Google Analytics to the Airflow doc website (#5763) [AIRFLOW-5148] Add Google Analytics to the Airflow doc website Aug 14, 2019
@mik-laj
Copy link
Member Author

mik-laj commented Aug 27, 2019

Close. There is already a MUCH better PR: #5930

@mik-laj mik-laj closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants