[AIRFLOW-5148] Adding GA and privacy notice to website#5930
Merged
kaxil merged 8 commits intoapache:masterfrom Aug 29, 2019
Merged
[AIRFLOW-5148] Adding GA and privacy notice to website#5930kaxil merged 8 commits intoapache:masterfrom
kaxil merged 8 commits intoapache:masterfrom
Conversation
5 tasks
Member
|
Travis is sad. Can you fix it? if you want I can help you tomorrow. I left my laptop charger in the office 😿 |
kaxil
reviewed
Aug 28, 2019
| lineage | ||
| changelog | ||
| faq | ||
| privacy_notice |
mik-laj
reviewed
Aug 28, 2019
mik-laj
reviewed
Aug 28, 2019
docs/templates/layout.html
Outdated
| <div class="footer">This page uses <a href="https://analytics.google.com/"> | ||
| Google Analytics</a> to collect statistics. You can disable it by blocking | ||
| the JavaScript coming from www.google-analytics.com. Check our | ||
| <a href="privacy_notice.html">Privacy Policy</a> |
Member
There was a problem hiding this comment.
Does it work on subpages?
For example:
On this page: https://airflow.readthedocs.io/en/latest/howto/operator/gcp/natural_language.html
This link will point to: https://airflow.readthedocs.io/en/latest/howto/operator/gcp/privay_notice.html
Member
There was a problem hiding this comment.
You are right. it won't work. Can you fix that, please?
Member
|
This message is not visible. It hides under other content. |
added 2 commits
August 28, 2019 17:24
Member
|
Fixed Preview for easier review: http://equal-system.surge.sh/ (Wed Aug 28 17:36:08 CEST 2019) |
added 2 commits
August 28, 2019 17:41
Member
|
Can it be merged now? It would be nice to have new documentation with this change. |
Jerryguo
pushed a commit
to Jerryguo/airflow
that referenced
this pull request
Sep 2, 2019
Co-authored-by: kaxil <kaxilnaik@gmail.com> Co-authored-by: mik-laj <kamil.bregula@polidea.com>
kaxil
pushed a commit
that referenced
this pull request
Sep 4, 2019
potiuk
pushed a commit
that referenced
this pull request
Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Description
Adding Google Analytics to the Website, along with a privacy notice to communicate to users about it, and about the sort of data being collected. This privacy notice is in line with other notices used in other Apache projects.
Reviewers: @kaxil