[AIRFLOW-XXX] Raise ValueError rather than assert in skip logic #5875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Description
This PR replaces an
assert
statement that exists in the SkipMixin class with raising aValueError
instead. The rationale for this is that assert statements should generally be reserved for testing and shouldn't exist in production logic, because they can be ignored in certain cases (specifically with thePYTHONOPTIMIZE
environment variable or-O
CLI flag.Tests
Tests already exist for this functionality.
Commits
Documentation
Code Quality
flake8