Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-XXX] Raise ValueError rather than assert in skip logic #5875

Merged
merged 1 commit into from
Aug 21, 2019
Merged

[AIRFLOW-XXX] Raise ValueError rather than assert in skip logic #5875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airflow/models/skipmixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ def skip(self, dag_run, execution_date, tasks, session=None):
synchronize_session=False)
session.commit()
else:
assert execution_date is not None, "Execution date is None and no dag run"
if execution_date is None:
raise ValueError("Execution date is None and no dag run")

self.log.warning("No DAG RUN present this should not happen")
# this is defensive against dag runs that are not complete
Expand Down