Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Airflow-4668] Make airflow/contrib/utils Pylint compatible #5916

Merged
merged 19 commits into from
Sep 4, 2019

Conversation

swiftomkar
Copy link
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-4668
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Makes airflow/contrib/utils pylint compatible

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    No change in code

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@swiftomkar swiftomkar changed the title Airflow 4668 [Airflow-4668] Make airflow/contrib/utils Pylint compatible Aug 26, 2019
swiftomkar and others added 2 commits August 26, 2019 23:12
Co-Authored-By: Ash Berlin-Taylor <ash_github@firemirror.com>
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes as they are look good, could you also fix up the associated test files:

./tests/contrib/utils/logging_command_executor.py
./tests/contrib/utils/run_once_decorator.py
./tests/contrib/utils/test_sendgrid.py
./tests/contrib/utils/test_weekday.py

@@ -37,6 +37,6 @@ def test_weekday_name_value(self):
self.assertEqual(e.name, weekday)
self.assertTrue(e in WeekDay)
self.assertTrue(0 < e < 8)
self.assertTrue(type(e) is WeekDay)
self.assertTrue(isinstance(e, WeekDay))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are here making changes could you correct these to:

         self.assertIsIinstance(e, WeekDay)

etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashb Done!

@ashb ashb merged commit 1384315 into apache:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants