-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Airflow-4668] Make airflow/contrib/utils Pylint compatible #5916
Conversation
…h_custom_formatter
airflow/contrib/utils/log/task_handler_with_custom_formatter.py
Outdated
Show resolved
Hide resolved
Co-Authored-By: Ash Berlin-Taylor <ash_github@firemirror.com>
airflow/contrib/utils/log/task_handler_with_custom_formatter.py
Outdated
Show resolved
Hide resolved
Co-Authored-By: Ash Berlin-Taylor <ash_github@firemirror.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes as they are look good, could you also fix up the associated test files:
./tests/contrib/utils/logging_command_executor.py
./tests/contrib/utils/run_once_decorator.py
./tests/contrib/utils/test_sendgrid.py
./tests/contrib/utils/test_weekday.py
tests/contrib/utils/test_weekday.py
Outdated
@@ -37,6 +37,6 @@ def test_weekday_name_value(self): | |||
self.assertEqual(e.name, weekday) | |||
self.assertTrue(e in WeekDay) | |||
self.assertTrue(0 < e < 8) | |||
self.assertTrue(type(e) is WeekDay) | |||
self.assertTrue(isinstance(e, WeekDay)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we are here making changes could you correct these to:
self.assertIsIinstance(e, WeekDay)
etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashb Done!
Make sure you have checked all steps below.
Jira
Description
Makes airflow/contrib/utils pylint compatible
Tests
No change in code
Commits
Documentation
Code Quality
flake8