Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5314] Create test for new import paths #5920

Merged
merged 1 commit into from
Sep 1, 2019

Conversation

turbaszek
Copy link
Member

This commit adds test for new import paths and and few missing files.

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This commit adds test for new import paths and and few missing files.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@turbaszek
Copy link
Member Author

@mik-laj @potiuk

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 27, 2019
@mik-laj
Copy link
Member

mik-laj commented Aug 29, 2019

It has conflict unfortunately. Can you fix it?

@turbaszek
Copy link
Member Author

Done

@turbaszek
Copy link
Member Author

Requires #5961

This commit adds test for new import paths and and few
missing files.
@mik-laj mik-laj merged commit 7ee2b99 into apache:master Sep 1, 2019
@mik-laj mik-laj added the AIP-21 label Sep 1, 2019
Jerryguo pushed a commit to Jerryguo/airflow that referenced this pull request Sep 2, 2019
@turbaszek turbaszek deleted the test-new-imports branch September 19, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants