Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5365] No need to do image rebuild when switching master/v1-1… #5972

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 31, 2019

…0-test

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Pre-commits should work now smoothly (no rebuilds triggered) when switching between master
and v1-10-test.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@potiuk
Copy link
Member Author

potiuk commented Sep 2, 2019

@kaxil @ashb - this one is really useful when cherry-picking and switching between branches.

@potiuk
Copy link
Member Author

potiuk commented Sep 2, 2019

Again here - it is rather small change and simple to review but as result any kind of cherry-picking is great and fully integrates with pre-commits while cherry-picking - so if we merge #5979 together with it we might save ton of time for cherry-picking python2 problems.

@ashb ashb merged commit 319b804 into apache:master Sep 3, 2019
potiuk added a commit that referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants