Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Improve the PubSub documentation #6511

Merged
merged 1 commit into from Nov 10, 2019

Conversation

TobKed
Copy link
Contributor

@TobKed TobKed commented Nov 6, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@TobKed
Copy link
Contributor Author

TobKed commented Nov 6, 2019

this PR refers to review made on PolideaInternal#401
CC @mschickensoup @mik-laj

@TobKed TobKed force-pushed the add-howto-pubsub-improvement branch from 1cebe0a to 9b8bc9f Compare November 7, 2019 10:57
@TobKed
Copy link
Contributor Author

TobKed commented Nov 7, 2019

CC @mik-laj @mschickensoup

@potiuk
Copy link
Member

potiuk commented Nov 7, 2019

@mschickensoup .. does it have your approval :)?

@mschickensoup
Copy link
Contributor

Let me re-phrase the description as well ;-) I've already done them, there's only one question reg. prepend in the JIRA section.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title e.g. "[AIRFLOW-XXX] My Airflow PR"

    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you fix a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue. || What did you mean by prepend was it supposed to be pretend?
    • In case you propose a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • If you add a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR including screenshots of some UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • All of my commits reference to Jira issues in their subject lines. I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@TobKed
Copy link
Contributor Author

TobKed commented Nov 7, 2019

In case you fix a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue. || What did you mean by prepend was it supposed to be pretend?

It means that commit should have [AIRFLOW-XXX] at the beginning of message. I think word prepend is correct here. Am I right @mschickensoup ?

@potiuk
Copy link
Member

potiuk commented Nov 8, 2019

@mschickensoup -> the description is from template in https://github.com/apache/airflow/blob/master/.github/PULL_REQUEST_TEMPLATE.md - I think it needs some love and simplification... Maybe you can have YOUR first PR to improve it....

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Nov 10, 2019
@potiuk potiuk merged commit 3651077 into apache:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants