Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6910] Fix kill_zombie method call #7531

Merged
merged 1 commit into from Feb 25, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Feb 25, 2020


Issue link: AIRFLOW-6910

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj requested a review from potiuk February 25, 2020 01:00
@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Feb 25, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d1a3424). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7531   +/-   ##
=========================================
  Coverage          ?   86.23%           
=========================================
  Files             ?      896           
  Lines             ?    42638           
  Branches          ?        0           
=========================================
  Hits              ?    36768           
  Misses            ?     5870           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/jobs/scheduler_job.py 87.69% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a3424...9933afe. Read the comment docs.

@Fokko
Copy link
Contributor

Fokko commented Feb 25, 2020

Thanks @mik-laj

@Fokko Fokko merged commit a62bb61 into apache:master Feb 25, 2020
@ashb
Copy link
Member

ashb commented Feb 25, 2020

@mik-laj @Fokko In situations like this can we please get in to the habit of targeting the bug fix at the same Jira issue as the original breaking change -- that way if we ever need to backport it we get the change and the fix. Two jiras means the fix is likely to get missed.

(Plus right now one PR = one Jira is just busy work, if we're going to do this lets just stop using Jira)

galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants