[AIRFLOW-6867] Fix bug in how we call kill_zombies #7534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor in apache#7488 introduced a scheduler-breaking bug.
ashb
changed the title
kaxil
reviewed
Feb 25, 2020
| @@ -877,7 +877,7 @@ def process_file(self, file_path, zombies, pickle_dags=False, session=None): | |||
| except Exception: | |||
| self.log.exception("Error logging import errors!") | |||
| try: | |||
| self.kill_zombies(zombies) | |||
| self.kill_zombies(dagbag, zombies) | |||
There was a problem hiding this comment.
Surprised that our static checkers didn't catch this! Required arg was not passed !
There was a problem hiding this comment.
Maybe pylint would have caught it but it is currently in pylint_todo, so might have missed:
airflow/scripts/ci/pylint_todo.txt
Line 11 in 6eaa7e3
There was a problem hiding this comment.
Tomek has the PR #7484 in progress for that.
kaxil
approved these changes
Feb 25, 2020
Fokko
approved these changes
Feb 25, 2020
|
Duplicate of #7531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor in #7488 introduced a bug.
I am not happy about merging this without a unit test to stop it breaking again, but given how much process_file does it's hard to test. Thoughts?
Issue link: AIRFLOW-6867
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.