[AIRFLOW-7075] Operators for storing information from GCS into GA #7743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:google
turbaszek
force-pushed
the
AIRFLOW-7075-gcs-to-GA
branch
from
eb42173
to
66346d6
Compare
|
This PR will have some conflicts with #7748 |
turbaszek
force-pushed
the
AIRFLOW-7075-gcs-to-GA
branch
from
66346d6
to
2bd8237
Compare
turbaszek
changed the title
airflow/providers/google/marketing_platform/example_dags/example_analytics.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/marketing_platform/example_dags/example_analytics.py
Show resolved
Hide resolved
| self._conn = None | ||
|
|
||
| def _paginate(self, resource: Resource, list_args: Optional[Dict[str, Any]] = None): | ||
| list_args = list_args or {} | ||
| result: List[Dict] = [] |
There was a problem hiding this comment.
I like it. Much better then mine.
| # the loop will be break | ||
| if response["totalResults"] <= len(result): | ||
| break | ||
| result = self._paginate(accounts) |
There was a problem hiding this comment.
Wow... brilliant.
airflow/providers/google/marketing_platform/operators/analytics.py
Outdated
Show resolved
Hide resolved
| WEB_PROPERTY_AD_WORDS_LINK_ID = "AAIIRRFFLLOOWW" | ||
| WEB_PROPERTY_ID = "web_property_id" | ||
| ACCOUNT_ID = "the_knight_who_says_ni!" | ||
| DATA_SOURCE = "Monthy Python" |
tests/providers/google/marketing_platform/operators/test_analytics_system.py
Show resolved
Hide resolved
turbaszek
commented
Mar 24, 2020
turbaszek
force-pushed
the
AIRFLOW-7075-gcs-to-GA
branch
from
209dfe6
to
ab9855b
Compare
… Google Analytics
turbaszek
force-pushed
the
AIRFLOW-7075-gcs-to-GA
branch
from
ab9855b
to
d30b891
Compare
potiuk
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operators for storing information from Google Cloud Storage into Google Analytics.
Issue link: AIRFLOW-7075
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.