New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6752] Add GoogleAnalyticsRetrieveAdsLinksListOperator #7748
[AIRFLOW-6752] Add GoogleAnalyticsRetrieveAdsLinksListOperator #7748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits mainly about documentation :).
# :type account_id: str | ||
# :param web_property_id: Web property ID to retrieve the Google Ads links for. | ||
# :type web_property_id: str | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to describe what are the results. What do they contain? Link to the doc in Google docs is enough but an example would be great.
airflow/providers/google/marketing_platform/example_dags/example_analytics.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/marketing_platform/operators/analytics.py
Outdated
Show resolved
Hide resolved
Would you mind adding a system tests: import pytest
from tests.providers.google.cloud.utils.gcp_authenticator import GMP_KEY
from tests.test_utils.gcp_system_helpers import MARKETING_DAG_FOLDER, GoogleSystemTest, provide_gcp_context
# Required scopes
SCOPES = [
'https://www.googleapis.com/auth/analytics',
'https://www.googleapis.com/auth/analytics.edit',
'https://www.googleapis.com/auth/cloud-platform',
]
@pytest.mark.system("google.marketing_platform")
@pytest.mark.credential_file(GMP_KEY)
class TestSystemGoogleAds(GoogleSystemTest):
@provide_gcp_context(GMP_KEY, scopes=SCOPES)
def test_run_example_dag(self):
self.run_dag('example_google_analytics', MARKETING_DAG_FOLDER) |
fixes after review
8c55966
to
b3c9093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The operator lists webProperty-Google Ads links for a given web property
Issue link: AIRFLOW-6752
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.