Custom Facebook Ads Operator #8008

randr97 · 2020-03-30T09:30:46Z

Issue link: WILL BE INSERTED BY boring-cyborg

Make sure to mark the boxes below before creating PR: [x]

Description above provides context of the change
Unit tests coverage for changes (not needed for documentation changes)
Commits follow "How to write a good git commit message"
Relevant documentation is updated including usage instructions.
I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

codecov-io · 2020-03-31T20:24:25Z

Codecov Report

Merging #8008 into master will decrease coverage by 0.44%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #8008      +/-   ##
==========================================
- Coverage   88.45%   88.00%   -0.45%     
==========================================
  Files         937      940       +3     
  Lines       45234    45353     +119     
==========================================
- Hits        40011    39913      -98     
- Misses       5223     5440     +217

Impacted Files	Coverage Δ
airflow/models/connection.py	`95.07% <ø> (ø)`
airflow/providers/facebook/ads/hooks/ads.py	`87.93% <87.93%> (ø)`
...le/facebook_ads_to_gcs/example_dags/example_ads.py	`100.00% <100.00%> (ø)`
...viders/google/facebook_ads_to_gcs/operators/ads.py	`100.00% <100.00%> (ø)`
airflow/utils/db.py	`98.37% <100.00%> (+0.01%)`	⬆️
airflow/kubernetes/volume_mount.py	`44.44% <0.00%> (-55.56%)`	⬇️
airflow/kubernetes/volume.py	`52.94% <0.00%> (-47.06%)`	⬇️
airflow/security/kerberos.py	`30.43% <0.00%> (-45.66%)`	⬇️
airflow/kubernetes/pod_launcher.py	`47.18% <0.00%> (-45.08%)`	⬇️
airflow/executors/sequential_executor.py	`56.00% <0.00%> (-44.00%)`	⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c8983...ff2fcf6. Read the comment docs.

airflow/providers/facebook/ads/hooks/ads.py

airflow/providers/facebook/ads/operators/ads.py

airflow/providers/facebook/ads/hooks/ads.py

airflow/providers/facebook/ads/example_dags/example_ads.py

airflow/providers/facebook/ads/hooks/ads.py

airflow/providers/facebook/ads/operators/ads.py

docs/operators-and-hooks-ref.rst

airflow/providers/facebook/ads/example_dags/example_ads.py

potiuk · 2020-04-13T07:51:50Z

Hey @randr97 -> I'd love to merge this one. Can you please rebase and regenerate the requirements?

randr97 · 2020-04-13T08:30:16Z

Hey @randr97 -> I'd love to merge this one. Can you please rebase and regenerate the requirements?

Sure thing, will do

potiuk · 2020-04-13T09:51:39Z

I think there was a change in MyPy in the meantime and you will have to wait until #8267 is merged (it fixes the problem) and rebase again I am afraid. Sorry for that.

potiuk · 2020-04-13T16:51:21Z

OK. You can rebase now - it should be fine :)

airflow/providers/google/facebook_ads_to_gcs/example_dags/example_ads.py

turbaszek · 2020-04-13T19:22:36Z

airflow/utils/db.py

+            {
+                "facebook_ads_client": {
+                    "account_id": "act_123456789",
+                    "app_id": "1234567890",
+                    "app_secret": "1f45tghxxxx12345",
+                    "access_token": "ABcdEfghiJKlmnoxxyz"
+                }
+            }
+            """,


I am not sure if we should keep dummy values here like that. Can we do this likewise gcp? schema="default"

Is there any better way to show the schema ?? Cus for GCP there is a tutorial on google's website. Integrating with airflow. Any thoughts?

boring-cyborg · 2020-04-14T13:08:38Z

Awesome work, congrats on your first merged pull request!

potiuk · 2020-04-14T13:08:47Z

Thanks @randr97 !

randr97 force-pushed the FacebookOperator branch 2 times, most recently from 765b87e to 43abe6b Compare March 30, 2020 09:33

mik-laj self-requested a review March 30, 2020 09:36

randr97 changed the title ~~Custom Facebook Ads Operator #7887~~ Custom Facebook Ads Operator Mar 30, 2020

randr97 force-pushed the FacebookOperator branch 7 times, most recently from 542db01 to 5040038 Compare March 31, 2020 10:54

boring-cyborg bot added area:CLI area:docs labels Mar 31, 2020

randr97 force-pushed the FacebookOperator branch from 5040038 to 8f1bf12 Compare March 31, 2020 10:58

boring-cyborg bot added the area:dev-tools label Mar 31, 2020

randr97 force-pushed the FacebookOperator branch 4 times, most recently from 0947c6f to ed5efc0 Compare March 31, 2020 19:28