Less aggressive eager upgrade of requirements #8267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
less-aggressive-requirements-upgrade
branch
from
2e46817
to
f52d997
Compare
boring-cyborg
bot
added
provider:Apache
provider:google
With this change requirements are only eagerly upgraded when generating requirements when setup.py changes. They are also eagerly upgraded when you run ./breeze generate-requirements locally. Still the cron job will use the eager update mechanism when building the docker image which means that CRON jobs will still detect cases where upgrede of requirements causes failure either at the installation time or during tests.
potiuk
force-pushed
the
less-aggressive-requirements-upgrade
branch
from
f52d997
to
e9ea2af
Compare
Codecov Report
@@ Coverage Diff @@
## master #8267 +/- ##
==========================================
- Coverage 88.34% 87.91% -0.43%
==========================================
Files 937 937
Lines 45231 45235 +4
==========================================
- Hits 39959 39769 -190
- Misses 5272 5466 +194
Continue to review full report at Codecov.
|
mik-laj
reviewed
Apr 13, 2020
| CURRENT_SETUP_PY_HASH=$(md5sum "${AIRFLOW_SOURCES}/setup.py") | ||
| STORED_SETUP_PY_HASH=$(cat "${STORED_SETUP_PY_HASH_FILE}" 2>/dev/null || true) | ||
|
|
||
| if [[ ${STORED_SETUP_PY_HASH} != "${CURRENT_SETUP_PY_HASH}" ]]; then |
There was a problem hiding this comment.
Suggested change
| if [[ ${STORED_SETUP_PY_HASH} != "${CURRENT_SETUP_PY_HASH}" ]]; then | |
| if [[ "${STORED_SETUP_PY_HASH}" != "${CURRENT_SETUP_PY_HASH}" ]]; then |
mik-laj
approved these changes
Apr 13, 2020
kaxil
approved these changes
Apr 13, 2020
potiuk
added a commit
that referenced
this pull request
Apr 15, 2020
With this change requirements are only eagerly upgraded when generating requirements when setup.py changes. They are also eagerly upgraded when you run ./breeze generate-requirements locally. Still the cron job will use the eager update mechanism when building the docker image which means that CRON jobs will still detect cases where upgrede of requirements causes failure either at the installation time or during tests. (cherry picked from commit 45c8983)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
With this change requirements are only eagerly upgraded when generating requirements when setup.py changes. They are also eagerly upgraded when you run ./breeze generate-requirements locally. Still the cron job will use the eager update mechanism when building the docker image which means that CRON jobs will still detect cases where upgrede of requirements causes failure either at the installation time or during tests. (cherry picked from commit 45c8983)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change requirements are only eagerly upgraded when
generating requirements when setup.py changes. They are also
eagerly upgraded when you run ./breeze generate-requirements
locally. Still the cron job will use the eager update mechanism
when building the docker image which means that CRON jobs will
still detect cases where upgrede of requirements causes failure
either at the installation time or during tests.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.