Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation description for repeatable PyPi installation #8513

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 22, 2020


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk force-pushed the add-installation-description-with-requirements branch from bb50337 to 23dc8de Compare April 22, 2020 10:16
Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add to docs/installation.rst?
https://airflow.readthedocs.io/en/latest/installation.html

@potiuk
Copy link
Member Author

potiuk commented Apr 22, 2020

Can you also add to docs/installation.rst?
https://airflow.readthedocs.io/en/latest/installation.html

Yep

@potiuk potiuk force-pushed the add-installation-description-with-requirements branch from 23dc8de to 37f9b84 Compare April 22, 2020 11:02
@potiuk
Copy link
Member Author

potiuk commented Apr 22, 2020

Fixed @mik-laj !

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
docs/installation.rst Outdated Show resolved Hide resolved
@mik-laj
Copy link
Member

mik-laj commented Apr 22, 2020

Do we need to copy the same information in two files? Is not enough short information in README.md and a link to the full guide on the website?.

@@ -87,6 +88,34 @@ For further information, please visit the [Airflow Wiki](https://cwiki.apache.or

Official container (Docker) images for Apache Airflow are described in [IMAGES.rst](IMAGES.rst).

## Installing from PyPI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding information about installing the master version (from github)?

@potiuk potiuk force-pushed the add-installation-description-with-requirements branch 2 times, most recently from c50e9e3 to 0064923 Compare April 22, 2020 12:27
@potiuk potiuk force-pushed the add-installation-description-with-requirements branch from 0064923 to bf3d7cf Compare April 22, 2020 12:28
@potiuk
Copy link
Member Author

potiuk commented Apr 22, 2020

Do you think it's worth adding information about installing the master version (from github)?

I think not. I actually removed the "installing from sources" from readme altogether. This is all explained in CONTIBUTING.rst: https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pinned-requirement-files

@potiuk
Copy link
Member Author

potiuk commented Apr 22, 2020

@kaxil @mik-laj -> I think it should be good to go :)

@potiuk potiuk merged commit 6d2e31c into apache:master Apr 22, 2020
@potiuk potiuk deleted the add-installation-description-with-requirements branch April 22, 2020 13:05
@potiuk potiuk added this to the Airflow 1.10.11 milestone Apr 26, 2020
potiuk added a commit that referenced this pull request Apr 26, 2020
potiuk added a commit that referenced this pull request Apr 26, 2020
potiuk added a commit that referenced this pull request Apr 26, 2020
potiuk added a commit that referenced this pull request Apr 26, 2020
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants