Focus upstream / downstream task dependencies on mouseover #9303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also include a before screenshot for comparison? |
done |
|
@ashb i updated it to remove one line that did not need to be there thanks |
feluelle
approved these changes
Jun 17, 2020
|
thanks @feluelle |
6 tasks
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2020
…over (#9303) * graph view mouseover task should increase stroke width of upstream / downstream * mouseover should focus dependencies on mouseover in graph view
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
…over (#9303) * graph view mouseover task should increase stroke width of upstream / downstream * mouseover should focus dependencies on mouseover in graph view
kaxil
pushed a commit
that referenced
this pull request
Aug 15, 2020
…over (#9303) * graph view mouseover task should increase stroke width of upstream / downstream * mouseover should focus dependencies on mouseover in graph view
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…over (apache#9303) * graph view mouseover task should increase stroke width of upstream / downstream * mouseover should focus dependencies on mouseover in graph view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently support focusing on upstream / downstream task dependencies in a mild way, namely by changing the color.
When you have a big messy dag, though, more aggressive focusing is desirable.
In this PR we enhance the focus on the upstream / downstream tasks by setting opacity of all other tasks and edges to 0.2.
This is the same approach that is already implemented in graph view when you mouseover task state, and when you use the search function to filter tasks.
Below are screenshots when the mouse is over dummy 3.
Before:
After:
Also
In this PR I also apply highlightStrokeWidth to focused tasks. If this one is merged, then #9297 is obsolete and can be closed.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.