-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ElasticsearchTaskHandler to the provider package #9623
Conversation
@ephraimbuddy can you please take a look at the CI errors? |
Hi @turbaszek , what could be the cause of the backport packages CI build error? I can't seem to figure it out |
Look at the logs @ephraimbuddy -> the "ExternalLoggingMixin" is a bit strange as I cannot see it in the logging_mixin. Where is it from? Traceback (most recent call last): ERROR ENCOUNTERED! |
We can't use ExtenralLoggingMixin in Airflow 1.10 providers because it only appeared .... TODAY in master |
If we want to support ExternalLoggingMixin we should also bacport it to 1.10 but this might be a bit more complex - using Bowler refactoring (@turbaszek WDYT?) |
@potiuk Thanks! |
@potiuk This will cherry-pick changes to the Javascript code. If you are willing, we can do it. For now, we should delete references to this class in backport packages. This will allow these classes to be used without this one new feature. |
These changes have been move to #9604 |
This PR fixes one of the issues listed in #9386
The
ElasticsearchTaskHandler
class fromairflow.utils.log.es_task_handler
was moved toairflow.providers.elasticsearch.log.es_task_handler
.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.