Skip to content

Move provider's log task handlers to the provider package#9604

Merged
turbaszek merged 18 commits intoapache:masterfrom
ephraimbuddy:cloudwatch
Jul 6, 2020
Merged

Move provider's log task handlers to the provider package#9604
turbaszek merged 18 commits intoapache:masterfrom
ephraimbuddy:cloudwatch

Conversation

@ephraimbuddy
Copy link
Contributor

@ephraimbuddy ephraimbuddy commented Jul 1, 2020


This PR fixes some of the issues listed in #9386
CloudwatchTaskHandler, StackdriverTaskHandler, and ElasticsearchTaskHandler were all moved from airflow/utils/log/ to their respective providers package

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:logging provider:amazon AWS/Amazon - related issues labels Jul 1, 2020
Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please take a look at the docs error?

@ephraimbuddy
Copy link
Contributor Author

Hi @turbaszek , please take a look.

@turbaszek
Copy link
Member

@ephraimbuddy please rebase, I've just merged this fix in #9628

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test in test_core_to_contrib.py?

@ephraimbuddy
Copy link
Contributor Author

Hi @turbaszek, I want to combine #9624 and #9623 into this PR so it can be merged at once. WDYT?

@mik-laj
Copy link
Member

mik-laj commented Jul 5, 2020

@ephraimbuddy +1 That shouldn't be a problem for us.

@ephraimbuddy ephraimbuddy changed the title Move CloudwatchTaskHandler to the provider package Move provider's log task handlers to the provider package Jul 5, 2020
@turbaszek turbaszek merged commit a79e2d4 into apache:master Jul 6, 2020
@ephraimbuddy ephraimbuddy deleted the cloudwatch branch July 6, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants