Move provider's log task handlers to the provider package#9604
Merged
turbaszek merged 18 commits intoapache:masterfrom Jul 6, 2020
ephraimbuddy:cloudwatch
Merged
Move provider's log task handlers to the provider package#9604turbaszek merged 18 commits intoapache:masterfrom ephraimbuddy:cloudwatch
turbaszek merged 18 commits intoapache:masterfrom
ephraimbuddy:cloudwatch
Conversation
turbaszek
approved these changes
Jul 1, 2020
Member
turbaszek
left a comment
There was a problem hiding this comment.
LGTM, can you please take a look at the docs error?
Contributor
Author
|
Hi @turbaszek , please take a look. |
turbaszek
approved these changes
Jul 1, 2020
feluelle
reviewed
Jul 2, 2020
Member
|
@ephraimbuddy please rebase, I've just merged this fix in #9628 |
turbaszek
approved these changes
Jul 3, 2020
turbaszek
reviewed
Jul 3, 2020
Member
There was a problem hiding this comment.
Would you mind adding a test in test_core_to_contrib.py?
Contributor
Author
|
Hi @turbaszek, I want to combine #9624 and #9623 into this PR so it can be merged at once. WDYT? |
Member
|
@ephraimbuddy +1 That shouldn't be a problem for us. |
This was referenced Jul 5, 2020
ephraimbuddy
commented
Jul 5, 2020
ephraimbuddy
commented
Jul 5, 2020
ephraimbuddy
commented
Jul 5, 2020
turbaszek
approved these changes
Jul 6, 2020
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some of the issues listed in #9386
CloudwatchTaskHandler,StackdriverTaskHandler, andElasticsearchTaskHandlerwere all moved fromairflow/utils/log/to their respective providers packageMake sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.