Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX Enhancement: Separate actions from links in DAG navigation #9894

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

ryanahamilton
Copy link
Contributor

  • Separates the "actions" (trigger, refresh, and delete) from the "view navigation" to visually differentiate between these two different logical groupings.
  • The action buttons all have tooltips and aria attributes to offset the removal of the text from the buttons.
  • Updated the icons used for "Trigger" and "Delete". The non-circled icons have a cleaner appearance in an icon-only button. These icons have also been updated in the "DAGs" index view.
  • Swapped the position of the "Tree View" and "Graph View" navigation links given "Tree View" is the default view when clicking from the "DAGs" index view.
  • UI screenshots in documentation have been updated to reflect these changes.

DAG Navigation - Before:
image

DAG Navigation - After:
image

DAGs Index Icons - Before:
image

DAGs Index Icons - After:
image


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:docs area:webserver Webserver related Issues labels Jul 20, 2020
Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. I started working on it once but never got motivated to finish it.
#4796

@ryanahamilton
Copy link
Contributor Author

@mik-laj ah, I hadn't seen that PR. Glad to see we're on the same page!

@ryw ryw self-requested a review July 20, 2020 17:49
Copy link
Member

@ryw ryw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement @ryanahamilton - looks good

@kaxil kaxil merged commit 273e28c into apache:master Jul 20, 2020
@kaxil
Copy link
Member

kaxil commented Jul 20, 2020

Nice work @ryanahamilton

@kaxil kaxil deleted the dag_navigation_ux branch July 20, 2020 18:05
@ryanahamilton ryanahamilton added the area:UI Related to UI/UX. For Frontend Developers. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants