AMBARI-24693. Remove ambari-infra and ambari-logsearch from ambari repository. #2387
Conversation
oleewere
requested review from
swagle,
adoroszlai,
jonathan-hurley and
avijayanhwx
There was a problem hiding this comment.
It's good to get this out of the ambari repo, but is it moving to its own repo, or to a child repo of Ambari? I've seen child repos before, like:
https://github.com/libretro-thumbnails/libretro-thumbnails
|
Refer to this link for build results (access rights to CI server needed): |
|
@jonathan-hurley it will go into its own repo, we wont use git submodules for that (then we would need to sync that sometimes), also we probably will have more frequent releases, in order if there is a fix for logsearch or solr, we do not need to ship ambari. also using its own repo more fits with apache gitbox ways, see: https://gitbox.apache.org/repos |
|
No problem, was just curious if you had considered the submodules for this. I suppose it's really best for projects with lots of different little repos, where you'd want to checkout and manage only a handful of them (as in libretro's case). I'm fine with Ambari projects having their own, isolated repos. Just wanted to bring it up and discuss it :) |
|
@jonathan-hurley, i think it would make sense to use git submodules only if we want to build the projects together, in our case that is the opposite. for instance: imagine that ambari-server is a git submodule as well not just these, and ambari repo would just store these modules, if we would release ambari, we would have to sync these git sub-modules, so it would be perfect to have them together (and those would be compatible with each other). probably these will be shipped at the same time for ambari 2.8, but on long term the goal is different, so it's no need to use git submodules here. |
* upstream/trunk: (99 commits) AMBARI-24708. Automation script for upgrade old style isilon cluster to the new mpack based structure (amagyar) (apache#2397) AMBARI-24700 - Slider widget: insert a space char between label value and unit-name (apache#2399) AMBARI-24245. Fix FindBugs warnings (apache#2398) AMBARI-24707. Build fails due to missing ambari-utility (apache#2395) [AMBARI-24706] Fix issues in ambari common python package publishing utility. (apache#2394) AMBARI-24669. Component status can stuck in starting/stopping status on heartbeat lost. (mpapirkovskyy) (apache#2385) [AMBARI-24696] UI: Options Page to choose Rolling or Express Restart. (apache#2389) AMBARI-24466. Add README.md for Ambari project (apache#2390) AMBARI-24672. Regenrating keytabs for services using all of their identities instead of service/component filtering (apache#2359) [AMBARI-24695] Remove ambari-metrics from ambari repository. (apache#2388) [AMBARI-24632] APT/DPKG existence check doesn't work for system packages (dgrinenko) (apache#2366) AMBARI-24693. Remove ambari-infra and ambari-logsearch from ambari repository. (apache#2387) [AMBARI-24691] Refactor Upgrade Classes to Proper Packages (apache#2386) AMBARI-24690. Ambari-server setup-ldap throws an error when the OU has spaces (amagyar) (apache#2382) [AMBARI-24685] - Create a Maven Consumable Ambari SPI Client Library [AMBARI-24687] Upgrade Pack Should Allow Source Information (apache#2375) [AMBARI-24682] Rolling Restarts: Option to specify number of failures per batch (dsen) (apache#2371) AMBARI-24670. Directory creation sometimes fails with parallel_execution=1 (aonishuk) AMBARI-24670. Directory creation sometimes fails with parallel_execution=1 (aonishuk) AMBARI-24689. All component statuses should be re-send on registration (aonishuk) ... # Conflicts: # README.md # ambari-common/src/main/python/resource_management/libraries/functions/module_version.py # ambari-common/src/main/python/resource_management/libraries/functions/mpack_version.py # ambari-server-spi/pom.xml # ambari-server/src/test/python/TestVersion.py # ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_with_source.xml # ambari-web/test/controllers/global/cluster_controller_test.js
* origin/trunk: (131 commits) AMBARI-24890 Restart option should not be shown if service components are not created in a cluster AMBARI-24877 Heatmap tab, metrics tab and QuickLinks section in summary tab should be hidden if service has only client service component AMBARI-24693. Remove ambari-infra and ambari-logsearch from ambari repository. (apache#2387) AMBARI-24620 Duplicate view of configurations in Add Service wizard AMBARI-24592 fix handling of stack defaults in blueprints (benyoka) (apache#2243) AMBARI-24890 Restart option should not be shown if service components are not created in a cluster AMBARI-24877 Heatmap tab, metrics tab and QuickLinks section in summary tab should be hidden if service has only client service component [AMBARI-24696] UI: Options Page to choose Rolling or Express Restart. (apache#2389) [AMBARI-24685] - Create a Maven Consumable Ambari SPI Client Library AMBARI-24662. Log Search: add simple LDAP authentication support (apache#2347) [AMBARI-24631] [Log Search UI] styles and layout fixes (apache#2339) AMBARI-24648. Log Search: add simple file based authorization. (apache#2336) AMBARI-24644. Log Search: support trusted knox proxy. (apache#2327) AMBARI-24620 Duplicate view of configurations in Add Service wizard AMBARI-23077. LogFeeder: create socket input. (apache#2260) AMBARI-24355. Logfeeder: create CLI for checkpoints and include log type in checkpoint file names. (apache#2245) AMBARI-24592 fix handling of stack defaults in blueprints (benyoka) (apache#2243) AMBARI-24343 - [LogSearch] Wrong (error) response format (apache#1962) AMBARI-24839. Ambari is trying to create hbase.rootdir using s3 url (apache#2609) AMBARI-24902. ATS 1.5 does not start in DL cluster without HDFS (aonishuk) (apache#2610) ...
What changes were proposed in this pull request?
Removed ambari-infra and ambari-logsearch modules from ambari repo.
they are moved to here:
https://github.com/apache/ambari-infra
https://github.com/apache/ambari-logsearch
Later we will need to mention that the repos was moved on ambari side, and listing the subprojects (like create a README.md for ambari and point to these repos), that can be done in a later PR, after metrics was removed as well
if from an Ambari 3.0.0 feature branch, a merge will happen, probably that can broke builds on RE side, but their work will be to fix that. For 2.8.0 RE will make builds to get ambari-infra/logsearch from different repos
How was this patch tested?
removed references for ambari-infra and ambari-logsearch from pom.xml, i would not expect this to fail
Please review @jonathan-hurley @swagle @adoroszlai @avijayanhwx