Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-24752 upgrade ambari-utility,ambari-server-spi deps for JDK11 #2434

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

g-boros
Copy link
Contributor

@g-boros g-boros commented Oct 9, 2018

Change-Id: Iaea6efbe1daa4e77576043584ab0c11c93a745ea

What changes were proposed in this pull request?

Add jaxb-api as maven dependency since it has been moved out of the language in JDK11.

How was this patch tested?

± % mvn -version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
Maven home: /usr/local/Cellar/maven@3.3/3.3.9/libexec
Java version: 11, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk-11.jdk/Contents/Home
Default locale: en_HU, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.4", arch: "x86_64", family: "mac"

± % mvn clean test -pl ambari-utility,ambari-server-spi
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Ambari Server SPI
[INFO] ambari-utility
...
...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Server SPI .................................. SUCCESS [  3.264 s]
[INFO] ambari-utility ..................................... SUCCESS [  3.519 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.181 s
[INFO] Finished at: 2018-10-09T14:49:08+02:00
[INFO] Final Memory: 35M/352M
[INFO] ------------------------------------------------------------------------

Please review @adoroszlai @oleewere @zeroflag

Change-Id: Iaea6efbe1daa4e77576043584ab0c11c93a745ea
@asfgit
Copy link

asfgit commented Oct 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4214/
Test FAILed.
Test FAILured.

@adoroszlai
Copy link
Contributor

Have to upgrade maven-shade-plugin, too, to avoid:

Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:2.3:shade (shade-zkmigrator) on project ambari-agent: Error creating shaded jar: null
...
Caused by: java.lang.IllegalArgumentException
    at org.objectweb.asm.ClassReader.<init> (Unknown Source)

https://issues.apache.org/jira/browse/MSHADE-242

diff --git a/ambari-agent/pom.xml b/ambari-agent/pom.xml
index 013e872f8a..aa87089f99 100644
--- a/ambari-agent/pom.xml
+++ b/ambari-agent/pom.xml
@@ -412,7 +412,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-shade-plugin</artifactId>
-        <version>2.3</version>
+        <version>3.2.0</version>
         <executions>
           <execution>
             <id>shade-zkmigrator</id>

Change-Id: Ife6ef364b23e1ae3bcf45e8c5a729275dc4263ef
@asfgit
Copy link

asfgit commented Oct 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4221/
Test PASSed.

Copy link
Contributor

@oleewere oleewere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adoroszlai adoroszlai merged commit bc3b720 into apache:branch-feature-jdk11 Oct 10, 2018
hapylestat pushed a commit to hapylestat/ambari that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants