Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-14387. Exclude "/tmp" and mountpoints from suggested service data directories #27

Closed
wants to merge 1 commit into from

Conversation

randerzander
Copy link

Added excluded /tmp and /etc mountpounts to ambari-agent

@afernandez
Copy link
Contributor

Hi,

Thank you for your contribution. Our dev process is to use patches and code reviews instead of pull requests.
https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute

Cheers,
Alejandro

@Jetly-Jaimin Jetly-Jaimin changed the title AMBARI-14387 AMBARI-14387. Exclude "/tmp" and mountpoints from suggested service data directories Jan 12, 2018
@Jetly-Jaimin
Copy link
Contributor

Copying description as present on Apache Jira:

Ambari agents running in Docker containers frequently have /tmp and /etc mountpoints. Between HDFS, ZooKeeper, HBase, and YARN configs, it's very easy to mistakenly accept a /tmp/hadoop suggested data directory. Any mountpoints with /tmp or /etc should be omitted.

@Jetly-Jaimin
Copy link
Contributor

@randerzander This patch completely masks the information of /etc and /tmp being mountpoints on hosts.

IMO even if /etc and /tmp are mountpoints on the hosts then the host API should keep showing that correct information but we can change the logic that recommends data directory for hadoop services to exclude /etc and /tmp mountpoints
Additionally if some user changes the recommended value to include /etc and /tmp mountpoints for data directories, we can validate and warn end user about it.

cc @u39kun

@asfgit
Copy link

asfgit commented Jan 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/86/
Test FAILed.
Test FAILured.

@jonathan-hurley
Copy link
Member

Closing as it seems this PR is stale and not being updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants