Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMBARI-25671] Moved cache deletion at the end in delete flow #3307

Open
wants to merge 1 commit into
base: branch-2.7
Choose a base branch
from

Conversation

shubhamod
Copy link

What changes were proposed in this pull request?

According to current delete flow, we are deleting the cache data first and then deleting data from db. But if due to anycase like Rollback exceptions , we delete the data from cache but data in DB is rollbacked. Due to this when again we try to delete the host data, it throws hostNotFound since it takes this check from cache given below.

Set clusters = getHostClustersMap().get(hostname);
if (clusters == null) {
throw new HostNotFoundException(hostname);
}

if (!getHostsByName().containsKey(hostname)) { throw new HostNotFoundException("Could not find host " + hostname); }

So even though data is not actually deleted from DB , we still wont delete from DB because of this. The current way is to restart ambari server which fills up the cache again and then it works fine, but until that, we wont be able to delete anything for this hostName.

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant